seancarmody / ngramr

R package to query the Google Ngram Viewer
Other
48 stars 9 forks source link

Apparent new problem. #40

Closed danhart228 closed 1 year ago

danhart228 commented 1 year ago

Hi,

Perhaps google has changed its site again?

ng <- ngram(c("hacker", "programmer"), year_start = 1950) Please check Google's Ngram Viewer site is up. Timeout was reached: [books.google.com] Send failure: Connection was aborted

ng <- ngram(c("hacker", "programmer"), year_start = 1950) Error parsing ngram data, please contact package maintainer. Here's the original error message: subscript out of bounds Error occurred in the following code: [[stringr::str_split(grep("drawD3Chart", years, value = TRUE), ",")1

seancarmody commented 1 year ago

Looks like it! Getting onto it now...

danhart228 commented 1 year ago

Many thanks for your attentiveness and your support of this great package!

Daniel Hart Prevention Science and Psychology Rutgers University-Camden


From: Sean Carmody @.> Sent: Thursday, October 6, 2022 5:03 PM To: seancarmody/ngramr @.> Cc: Daniel Hart @.>; Author @.> Subject: Re: [seancarmody/ngramr] Apparent new problem. (Issue #40)

Looks like it! Getting onto it now...

— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fseancarmody%2Fngramr%2Fissues%2F40%23issuecomment-1270695391&data=05%7C01%7Chart%40camden.rutgers.edu%7Cb5223c4c92a0423b7c4608daa7de2b25%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C638006869899295826%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=7FgAn8pDx%2FuaajYRnS1rqzlGKLWqTf%2BrJjJ2iUVdipE%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA266SFHDLKHWIZ7TCMRTUEDWB45AVANCNFSM6AAAAAAQ65V2KY&data=05%7C01%7Chart%40camden.rutgers.edu%7Cb5223c4c92a0423b7c4608daa7de2b25%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C638006869899452055%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4qE9kpjqlbFcnLbn6%2FFlw1IPDIDLcEJgyx%2BSXnOtcgw%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

seancarmody commented 1 year ago

Yes, Google updated their site (again) which broke my code. I have made some modifications which should make it work now. I will complete testing and republish to CRAN. In the meantime you can try out the development version. This requires use of the dev tools package, so install that if you haven't already and then try:

library(devtools)
install_github("seancarmody/ngramr", "develop")
library(ngramr)

Let me know if that works.

danhart228 commented 1 year ago

Outstanding! Working perfectly, as far as I can tell. Many, many thanks!

Daniel Hart Prevention Science and Psychology Rutgers University-Camden


From: Sean Carmody @.> Sent: Friday, October 7, 2022 7:08 AM To: seancarmody/ngramr @.> Cc: Daniel Hart @.>; Author @.> Subject: Re: [seancarmody/ngramr] Apparent new problem. (Issue #40)

Yes, Google updated their site (again) which broke my code. I have made some modifications which should make it work now. I will complete testing and republish to CRAN. In the meantime you can try out the development version. This requires use of the dev tools package, so install that if you haven't already and then try:

library(devtools) install_github("seancarmody/ngramr", "develop") library(ngramr)

Let me know if that works.

— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fseancarmody%2Fngramr%2Fissues%2F40%23issuecomment-1271451257&data=05%7C01%7Chart%40camden.rutgers.edu%7C883db5199db5422a715d08daa8543642%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C638007376907300479%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=YDQS4Z6opXuEtYEUv%2FqphIMf1x9pVYWIzrZ85DlhtBs%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA266SFGZD6LFOQNQL3PW56LWCAABNANCNFSM6AAAAAAQ65V2KY&data=05%7C01%7Chart%40camden.rutgers.edu%7C883db5199db5422a715d08daa8543642%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C638007376907300479%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=anQGNlxrTKP4ffp4cCMytp0nKcHjVo0U0cFKjFMZxOc%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

seancarmody commented 1 year ago

Thanks. Updated version now published on CRAN.