search

seancorfield / next-jdbc

A modern low-level Clojure wrapper for JDBC-based access to databases.
https://cljdoc.org/d/com.github.seancorfield/next.jdbc/
Eclipse Public License 1.0
768 stars 90 forks source link

Not all builders yield :cols / :rsmeta #130

Closed seancorfield closed 4 years ago

seancorfield commented 4 years ago

An assumption has crept in that all builders have :cols and :rsmeta elements that can be looked up. That isn't currently true of adapters so those builders will not behave correctly when used in several situations. This should be fixed before any more open adapter is added.

seancorfield commented 4 years ago

The two existing adapters must implement clojure.lang.ILookup and delegate to the adapted builder.

Need to add tests around this: wrap an adapter in an adapter and verify it can read columns correctly, also indexed access in plan when the builder is an adapter.