search

seancorfield / next-jdbc

A modern low-level Clojure wrapper for JDBC-based access to databases.
https://cljdoc.org/d/com.github.seancorfield/next.jdbc/
Eclipse Public License 1.0
760 stars 90 forks source link

Add missing arity to component spec #131

Closed Briaoeuidhtns closed 4 years ago

Briaoeuidhtns commented 4 years ago

The close function was missing in the spec for connection/component.

I don't know if there's a way to specify the close-fn args more specifically without hitting generative testing, but if there is I couldn't find it. Seems like it's built in to fspec and doesn't have a clear way to disable.

As a side note, it's also the only spec'ed function not in fns-with-specs. I don't know if that was just an oversight or intentional, so I left it as is.

seancorfield commented 4 years ago

Thanks. I'll probably change ifn? to fn? since it is an actual function, not just something that is "function-like". The omission from fns-with-specs is an oversight on my part, and I probably need to review that against a list of newly-added functions to make sure a) I have specs for all the API pieces and b) the list is complete. I'll create another issue for that to remind myself!