search

seancorfield / next-jdbc

A modern low-level Clojure wrapper for JDBC-based access to databases.
https://cljdoc.org/d/com.github.seancorfield/next.jdbc/
Eclipse Public License 1.0
768 stars 90 forks source link

Remove extra assert from `as-...` result set functions? #89

Closed serioga closed 4 years ago

serioga commented 4 years ago

I feel like these asserts are not needed because they check for options which are checked again in the underlying function.

https://github.com/seancorfield/next-jdbc/blob/c17a425df6176f7cd45d4fad5a8f146b2400ee4a/src/next/jdbc/result_set.clj#L170-L180

Not everyone disable asserts in production :-)

seancorfield commented 4 years ago

Good idea! Done.