search

seancorfield / usermanager-example

A little demo web app in Clojure, using Component, Ring, Compojure, Selmer (and a database)
Other
338 stars 38 forks source link

Unused parameter in WebServer component #12

Closed michaelrkytch closed 1 year ago

michaelrkytch commented 1 year ago

The 'server' parameter of WebServer in usermanager.main is unused.

seancorfield commented 1 year ago

Thanks for the PR. It was leftover from an earlier version where you could specify :jetty or :http-kit to show how easy it was to swap web servers -- but it just added unnecessary noise to the example so I took that logic (and documentation) out... but missed the server parameter!

michaelrkytch commented 1 year ago

Cool. This project was very helpful in putting together my first Clojure web app. I used a slightly different stack, but this helped me organize components and improve my workflow.