seandavi / orchestra-contributions

For submitting and tracking Orchestra training platform contributions
Creative Commons Zero v1.0 Universal
0 stars 0 forks source link

How to update workshop #16

Closed jmacdon closed 2 years ago

jmacdon commented 2 years ago

Hi Sean,

My workshop depends on an AnnotationHub object that isn't downloading, so I changed to something that will download. It is apparently building the HTML vignette now (https://github.com/jmacdon/Bioc2022Anno/runs/7528389476?check_suite_focus=true), but I don't see the HTML vignette on orchestra, nor if I get the updated docker container. Is there something additional I need to do to push the updated package?

Thanks,

Jim

seandavi commented 2 years ago

Orchestra will pull the latest image, so if you update the docker, things should be good. Once the build is done, give it a try. If you still have problems, follow up and I'll look into it.

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: James W. MacDonald @.> Sent: Tuesday, July 26, 2022 6:35:20 PM To: seandavi/orchestra-contributions @.> Cc: Subscribed @.***> Subject: [seandavi/orchestra-contributions] How to update workshop (Issue #16)

Hi Sean,

My workshop depends on an AnnotationHub object that isn't downloading, so I changed to something that will download. It is apparently building the HTML vignette now (https://github.com/jmacdon/Bioc2022Anno/runs/7528389476?check_suite_focus=true), but I don't see the HTML vignette on orchestra, nor if I get the updated docker container. Is there something additional I need to do to push the updated package?

Thanks,

Jim

— Reply to this email directly, view it on GitHubhttps://github.com/seandavi/orchestra-contributions/issues/16, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAAWSE4GHZ4LG52IKQQQBEDVWB74RANCNFSM54XYQG5A. You are receiving this because you are subscribed to this thread.Message ID: @.***>

jmacdon commented 2 years ago

That's the thing. I've updated GitHub and the actions seem to go OK, but neither the docker nor the orchestra site seem to have the HTML version of the vignette.

gartician commented 2 years ago

I also got a PR accepted (CITEViz #10, Friday 15:30) and I'm not seeing an HTML vignette on my package demo in this webpage.

jdrnevich commented 2 years ago

Hi Garth,

Orchestra and the website are two different things. You were supposed to have emailed @.**@.> with the links to put on the website. We will work to put these in for all Orchestra workshops today.

Thanks, Jenny

From: Garth Kong @.> Sent: Tuesday, July 26, 2022 11:37 PM To: seandavi/orchestra-contributions @.> Cc: Subscribed @.***> Subject: Re: [seandavi/orchestra-contributions] How to update workshop (Issue #16)

I also got a PR accepted (CITEViz #10https://urldefense.com/v3/__https:/github.com/seandavi/orchestra-contributions/issues/10__;!!DZ3fjg!9IsMEiSMP4c8EwMRGvSjTK60GV_PQw-k5lRulv3pzsfs84CE_GuV7aRbPqkc0HdJNybYnq-4DdFSRQRuT-W2JMu0NV4$, Friday 15:30) and I'm not seeing an HTML vignette on my package demo in this webpagehttps://urldefense.com/v3/__https:/bioc2022.bioconductor.org/workshops/__;!!DZ3fjg!9IsMEiSMP4c8EwMRGvSjTK60GV_PQw-k5lRulv3pzsfs84CE_GuV7aRbPqkc0HdJNybYnq-4DdFSRQRuT-W2x1K1Sjk$.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/seandavi/orchestra-contributions/issues/16*issuecomment-1196257152__;Iw!!DZ3fjg!9IsMEiSMP4c8EwMRGvSjTK60GV_PQw-k5lRulv3pzsfs84CE_GuV7aRbPqkc0HdJNybYnq-4DdFSRQRuT-W2N8kPZa8$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ACREQWPMRCH2PTUVKYRR4ETVWC4H3ANCNFSM54XYQG5A__;!!DZ3fjg!9IsMEiSMP4c8EwMRGvSjTK60GV_PQw-k5lRulv3pzsfs84CE_GuV7aRbPqkc0HdJNybYnq-4DdFSRQRuT-W2x2kLYZk$. You are receiving this because you are subscribed to this thread.Message ID: @.***>

seandavi commented 2 years ago

@jmacdon Orchestra should point to your html now--just had to change the workshop URL to point to the HTML rather than github. I need to clarify the instructions.

The HTML vignette doesn't end up in the docker, just the Rmd. I guess I could try to change that behavior if you think it would be useful to do so. I've been operating under the model that folks will go to the website for HTML.

jmacdon commented 2 years ago

@seandavi This is something I asked you about previously. I assume you are saying that orchestra is pointing to my githubio page, but that page doesn't have the vignettes. It's not like your page at all. https://jmacdon.github.io/Bioc2022Anno/

seandavi commented 2 years ago

I see what you are saying, @jmacdon. I see that the files in the gh-pages branch of your repo are correct for a pkgdown site. However, your site has only the README content on it. Could you double-check under Settings -> General -> Pages that the gh-pages branch is chosen as the source for Pages?

jmacdon commented 2 years ago

It is now. I must have missed that in the documentation! I assume I now just force the GitHub action to go again?

jmacdon commented 2 years ago

Ah, never mind. It builds automatically. Thanks @seandavi

seandavi commented 2 years ago

Glad we got it worked out. I think you have one of the longest-running workshops, so we have to make sure it goes by without a hitch! 😃