search

seandepagnier / celestial_navigation_pi

celestial navigation plugin for opencpn
17 stars 21 forks source link

Protect IGRF11.cof and vsop87d.txt from corruption #22

Closed rgleason closed 6 years ago

rgleason commented 6 years ago

I notice that these two data files are in system directly C:\Program Files (x86)\OpenCPN\plugins\celestial_navigation_pi\data where they are protected from the user messing with them. (good)

However both of these files are in my C:\ProgramData\opencpn\plugins\celestial_navigation too. I don't believe they are necessary there as they are static files that are just read for data. I believe these two files should be removed so the user cannot read and unintentionally modify them.

rgleason commented 6 years ago

I believe this was fixed by

https://github.com/seandepagnier/celestial_navigation_pi/commit/9058122fe658622b8f2f8ef20f5f0b4ad24c9eb2

However the location is in the USER folder ProgramDATA which is a problem, IMHO because the user can change it accidentally.

Also there should be a notice to the user if these files are corrupted. SEE PR https://github.com/seandepagnier/celestial_navigation_pi/pull/20