seandepagnier / weather_routing_pi

weather routing plugin for opencpn
GNU General Public License v3.0
47 stars 35 forks source link

Detect Land (Islands) does not seem to work. Is it Gshhg? #195

Closed rgleason closed 6 years ago

rgleason commented 6 years ago

Turks and Caicos doesn't seem to be recognized. I had 6 hour interval. It went acrross with the optimal route calc points in the water but still crossing. Reduced to interval 1hr and the calc points for opt route seem to be landing on land. screenshot 65 screenshot 64

rgleason commented 6 years ago

screenshot 66 screenshot 67

I don't think the segment between optimal isochrones is being calculated for interference with land. Also I don't think the actual optimal isochrone points are being calculated for interference with land now.

rgleason commented 6 years ago

See this comment pllease https://github.com/seandepagnier/weather_routing_pi/issues/196#issuecomment-385009525

rgleason commented 6 years ago

Still testing and Land Detect seems to miss things. screenshot 69

Using the grib and weatherconfig here https://github.com/seandepagnier/weather_routing_pi/issues/196#issue-318450293

Last Jolly Harbor to Fort Pierce configuration.

rgleason commented 6 years ago

Put a new boundary around Nassau, and boundary now seems to be working. See https://github.com/seandepagnier/weather_routing_pi/issues/191#issuecomment-385174865

nohal commented 6 years ago

These screenshots are not very helpful, please show us the GSHHG basemap on them, that is what WR uses o detect land.

rgleason commented 6 years ago

Duh! I had just figured it out. --No land there. screenshot 72

So detect land is working. The gshhg is just not detailed enough.

rgleason commented 6 years ago

So now I think this issue is closed. Sorry.