search

seandepagnier / weatherfax_pi

weather fax plugin for opencpn
GNU General Public License v3.0
20 stars 27 forks source link

Missing include file wxWTranslateCatalog.h #112

Closed rgleason closed 5 years ago

rgleason commented 5 years ago

The plugin seems to be missing an include file wxWTranslateCatalog.h

" c:\project\weatherfax_pi\src\WeatherFaxUI.h(47): fatal error C1083: Cannot open include file: 'wxWTranslateCatalog.h': No such file or directory [C:\project\weatherfax_pi\build\weatherfax_pi.vcxproj]"

I think it would be best to get this working for ov4.2 - ov4.8.8 with wxwidgets 3.0.2 first before moving to ov50 and wxwidgets 3.1.2

It would be really nice to get this working with ov50

I suppose we could just backup and abandon the Android changes to get it working and then proceed with moving to ov50

rgleason commented 5 years ago

Found this https://github.com/OpenCPN/OpenCPN/blob/master/plugins/wmm_pi/cmake/wxWTranslateCatalog.h.in

Also this Issue #108 A Clean Git does not Compile.

wxWTranslateCatalog.h isn't generated by cmake anymore.

git show -p 377538c cmake/PluginConfigure.cmake

Also https://github.com/seandepagnier/weather_routing_pi/issues/236

The change introduced for support Android on Sept 16th, 2018 breaks the Linux build as the file wxWTranslateCatalog.h is not created and so end being missing. The cause was introduced by the commit 8a59445 As it is the plugin cannot be compiled for Linux.

rgleason commented 5 years ago

https://github.com/seandepagnier/weather_routing_pi/commit/8a59445ac7489e79bd5edb18d0b7b10bd49013d6#diff-af3b638bc2a3e6c650974192a53c7291R70

cmake/pluginconfigure.cmake on Line 93 removes this statement

configure_file(cmake/wxWTranslateCatalog.h.in ${PROJECT_SOURCE_DIR}/src/wxWTranslateCatalog.h)

This is why wxWTranslateCatalog.h does not exist. Perhaps we should just put that line back in and let Sean figure out how to make Android work?

rgleason commented 5 years ago

It compiles now and have made a PR#113 https://github.com/seandepagnier/weatherfax_pi/pull/113

rgleason commented 5 years ago

Closed