search

seandepagnier / weatherfax_pi

weather fax plugin for opencpn
GNU General Public License v3.0
20 stars 27 forks source link

Xml update, stelian miscell ui fixes, ov50 appveyor, "ov50" in file name #131

Closed rgleason closed 5 years ago

rgleason commented 5 years ago

Sean, I am going to put the ov42 and ov50 versions into github "Releases", but I very much like to get the Windows Release files automatically uploaded to your github "Releases" somehow. Then I will stop making the window release files.

seandepagnier commented 5 years ago

Doesn't appveyor make releases automatically?

On 4/14/19, Rick Gleason notifications@github.com wrote:

Sean, I am going to put the ov42 and ov50 versions into github "Releases", but I very much like to get the Windows Release files automatically uploaded to your github "Releases" somehow. Then I will stop making the window release files.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/seandepagnier/weatherfax_pi/pull/131#issuecomment-483064871

nohal commented 5 years ago

Doesn't appveyor make releases automatically?

It can if configured so

rgleason commented 5 years ago

The appveyor file created is not successfully uploaded to github unless the proper permission is given. IE: The windows appveyor file can be successfully created and actually exist in the "Artifacts" Tab, but if the github authorization & security is not set up, there will be a red X on appveyor with a 401 Fail note, because the successfully created appveyor file is not uploaded to github "Release".

Sorry I even mentioned it. You need to merge these PR's if you are going to support Windows Users.

I will get my repository working, next and advise further, however these PR need to be merged, in the order suggested.

  1. XML update PR #126
  2. Miscellaneous UI Fixes PR #129
  3. ov42 - PR #130
  4. ov50 - PR #131
rgleason commented 5 years ago

Sean I see you just merged the first three. Thank you. The conflicting file for ov50 - PR #131 is VERSION.cmake and the conflict is created by the change to ov50 I think.

How would I resolve this? (It should be "ov50" to match the new version of appveyor.yml.)

And this looks right to me, https://github.com/seandepagnier/weatherfax_pi/pull/131/commits/e01ff6595404565a75e47df6621f240f118e3924

but it appears to be missing the necessary changes to appveyor.yml to compile for ov50! I am puzzled why the changes to this file are missing! Please see https://github.com/seandepagnier/weatherfax_pi/pull/131/commits/7c2c2b7f4ee42cf3542d7cca0f4feb39f072d74e which is included in this PR.

rgleason commented 5 years ago

Maybe I should just make a new PR for ov50 with the new appveyor.yml and VERSION.cmake? Perhaps that is easiest.

rgleason commented 5 years ago

Sean, I am going to close this and make a new one. Something doesn't look right with appveyor

rgleason commented 5 years ago

No, not for the windows exe.
I have been working on this problem and I have it configured correctly, except I believe that I don't have the right authorizations.

I've been working on branch "deploy-windows"

First I tried a Public key appveyor deploy key. That did not work.

The I tried an Oauth authorization - Personal Token with Yaml encryption of the public key after checking the "repo" scope. I might need to check an additional "scope" beyond "repo", perhaps check "admin.hook"

I've been at this for days, drip drip and doing other things too. I am not going to stop until I get it right.

The error message is consistently

Error creating GitHub release: Provider setting not found or it's value is empty. If secure setting is used please check that value was encrypted (or YAML was exported) while being logged under correct account. Parameter name: auth_token

The two appveyor posts I've created are:

https://help.appveyor.com/discussions/questions/36989-does-full-control-of-repository-hooks-grant-read-write-if-auth-is-ok

https://help.appveyor.com/discussions/problems/23134-push-built-file-to-opensource-public-github-release

Nobody really helps there. I am have an appveyor config that will push an Appveyor artifact file up to the github "Release" directory when a git push origin [new tag] git push origin v1.9.3-ov42 is issued, but I haven't got the certificate working yet.

I know it is a security problem from this https://github.com/settings/security

I do not know if I need to be an "organization". I hope not.