search

seandooa / pe

0 stars 0 forks source link

Editing the storage data manually causes the app to crash on load #12

Open seandooa opened 3 months ago

seandooa commented 3 months ago

"A" was put at the end of the salary entry instead of "I"

image.png

image.png

This caused the program to crash on startup.

image.png

soc-se-bot commented 3 months ago

Team's Response

Although I think that there should be proper exception handling for incorrect file inputs, I believe this bug is a case of extreme user input. The user should not be changing anything in the file directly. If the user wishes to use the same file, it has been recommended in the user guide to copy the full file instead of just the text. Hence, in no situation should the contents be manually changed by the user. Furthermore, the save function of the app would not produce such cases. Therefore, I will reject this bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I disagree with the point that the user should not be changing anything in the file directly, as one of the tp constraints is for the text file to be human editable.

image.png

However, I do understand that it has been explicitly stated in the user guide on how to transfer data and only a smaller subset of users will actually be editing the text file themselves. Hence, I propose to change the severity from High to Medium since does not affect most users but only some.

image.png