seandooa / pe

0 stars 0 forks source link

Removing the floating point number in the data file causes program to crash #13

Open seandooa opened 3 months ago

seandooa commented 3 months ago

When "0.00" is removed, the program crashes on login. This is quite possible as users may miss it out when copying entries from their existing data file to another one. Decimal in question image.png

Crash:

image.png

nus-se-bot commented 3 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Editing the storage data manually causes the app to crash on load

"A" was put at the end of the salary entry instead of "I"

image.png

image.png

This caused the program to crash on startup.

image.png


[original: nus-cs2113-AY2324S2/pe-interim#391] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Although I think that there should be proper exception handling for incorrect file inputs, I believe this bug is a case of extreme user input. The user should not be changing anything in the file directly. If the user wishes to use the same file, it has been recommended in the user guide to copy the full file instead of just the text. Hence, in no situation should the contents be manually changed by the user. Furthermore, the save function of the app would not produce such cases. Therefore, I will reject this bug.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I disagree with the point that the user should not be changing anything in the file directly, as one of the tp constraints is for the text file to be human editable. ![image.png](https://raw.githubusercontent.com/seandooa/pe/main/files/1428ad08-0841-4ffb-b96e-0d8aa0cc963b.png) However, I do understand that it has been explicitly stated in the user guide on how to transfer data and only a smaller subset of users will actually be editing the text file themselves. Hence, I propose to change the severity from High to Medium since does not affect most users but only some. ![image.png](https://raw.githubusercontent.com/seandooa/pe/main/files/39665583-5db9-4459-a3c8-c92e49b2df67.png)