search

seandooa / pe

0 stars 0 forks source link

Class labels in sequence diagram are missing semicolon #18

Open seandooa opened 5 months ago

seandooa commented 5 months ago

The class labels are missing semicolons, which is part of the format taught in this course. image.png

soc-pe-bot commented 5 months ago

Team's Response

We were not aware of any semicolons being required for the class diagram labels.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I can understand your point of view since I also can't find it explicitly stated in the course materials anywhere. However this information was based off the TA's DG review on my own sequence diagram which pointed out missing colons on entities as shown here:

image.png

Additionally the example sequence diagrams in the course materials also include the colon, an example of which is shown below:

image.png

Hence in this case I would choose to stand by my original argument. However, reflecting on it now I do believe it can be considered a mere cosmetic flaw as it does not take away from the information of the diagram. Thus, I would like to change the proposed severity to VeryLow.