seandooa / pe

0 stars 0 forks source link

File is saved when inputs not needing saving are used #3

Open seandooa opened 5 months ago

seandooa commented 5 months ago

Good that error handling is done for invalid commands, however not sure why the file needs to be saved and the user notified after every invalid command since an invalid command should not do anything that needs to be saved. Other commands like help and view-history also prompt the save message although there is no new data to be saved which may clutter the user experience.

For invalid command:

image.png

For help command:

image.png

soc-pe-bot commented 5 months ago

Team's Response

file is actually being saved at every command to ensure accuracy

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I do agree with the reasoning that saving the data file after every command is a way to ensure accuracy, however the user does not need to be notified of this process when the command they entered does not require any saving. An example is view-history all, which just lists the inflows and outflows. It also does not make sense for the user to be notified of their data being saved after inputting an invalid command.

As mentioned in my original report, this clutters the user experience, especially considering that this is a CLI based app with a lot of text on the screen. Perhaps another way could be to leave the file saving as a background process to the user (i.e they are not notified that it is actually being done) except for when their command explicitly requires saving, like adding an inflow/outflow.

Since this is purely a cosmetic issue, I have assigned it VeryLow in my initial report.