search

seanfisk / python-project-template

A template Python project with a focus on best practices.
Other
543 stars 168 forks source link

only install argparse as separate package for specific Python versions #24

Closed bitmensch closed 11 years ago

bitmensch commented 11 years ago

This solves #22.

seanfisk commented 11 years ago

I thought there might be a problem with removing argparse from the requirements file for 2.6, but tox and Travis-CI seem to have handled it fine. Does tox install the packages listed in the install_requires keyword?

Also, what do you think about people who are just working with 2.6? Will they be smart enough to know that argparse needs to be installed for development?

bitmensch commented 11 years ago

Yes, tox installs the packages listed in the install_requires keyword automatically.

For people who are working with Python 2.6 we may either add a hint in README.rst to run python setup.py develop after doing pip install -r requirements-dev.txt, and/or print additional step when generate.py completes.

seanfisk commented 11 years ago

Sounds perfect to me. How about leaving argparse commented out in requirements-dev.txt as well?

seanfisk commented 11 years ago

Yes, yes I do. Sorry for the confusion.

On Wed, Jul 31, 2013 at 1:34 PM, Benjamin Schwarze <notifications@github.com

wrote:

I guess you mean requirements.txt?

— Reply to this email directly or view it on GitHubhttps://github.com/seanfisk/python-project-template/pull/24#issuecomment-21889341 .

bitmensch commented 11 years ago

Done.

@seanfisk If you are satisfied with this version, please go ahead and merge into master.

seanfisk commented 11 years ago

Looks great!