Closed bitmensch closed 11 years ago
@seanfisk Did you had a chance to have a look at this PR? I haven't updated the documentation yet (waiting for your feedback), but could do this in a next step.
Hi Ben, sorry, been busy the last couple days.
This is quite a bit of a hack but genius at the same time because it certainly works. There are a couple issues I see, which are not necessarily the direct result of this PR...
/setup.py
should be remove from the .gitignore
.requirements/
(test, run, and dev) directory, the setup.py
(run) file, and tox.ini
(dev).tox.ini
and it works just fine. Running py.test
directly is not DRY and skips flake8 style, lint, and complexity checks. Since those are part of the normal testing procedure, they should be included. Even though it doesn't work great for everything, I'd like to try to make paver the gateway to all other utilities in the project (which I'm sure you've seen).The root of the issue is that there are a lot of marginally overlapping tools from which we want specific features.
@seanfisk Thanks for your feedback. I'll try to address these issues and come up with an updated more cleaner (read DRY) solution. I already have some ideas how to get this solved.
@seanfisk Incorporated all your feedback in separated commits. Please review.
@benjixx At a glance, this looks really good, Ben. I will test today and, assuming no problems, should have it merged by the end of the day.
@benjixx Actually, it looks like I won't be able to do it today. I will try to have it merged tomorrow night or Monday morning.
This is very good. Thanks for the PR, Ben.
@benjixx This tests documentation generation, too, correct?
Yes, that's correct. I have seen something like this in the tox examples and thought it would be a good addition to our current tests as documentation generation is something that could fail too.
That's definitely a good addition. I was also pleasantly surprised by the Travis-CI output, although it is a bit confusing to see 2.7 as the version for all jobs in the matrix. Luckily the tox environment variable is also listed. Not much can be done there, though. Too bad Travis-CI doesn't support tox directly as it does RVM for Ruby.
In preparation for tox I created
setup.py.tpl
which provides itssetup_dict
to paver, and lets tox use its default installation procedure.Additionally, I've set
tox.ini
to support only py26 and py27 right now as py33 probably might not work out-of-the box yet. Please give it a try and provide feedback.