seanfisk / python-project-template

A template Python project with a focus on best practices.
Other
543 stars 168 forks source link

Support for testing multiple Python versions with tox #4

Closed bitmensch closed 11 years ago

bitmensch commented 11 years ago

In preparation for tox I created setup.py.tpl which provides its setup_dict to paver, and lets tox use its default installation procedure.

Additionally, I've set tox.ini to support only py26 and py27 right now as py33 probably might not work out-of-the box yet. Please give it a try and provide feedback.

bitmensch commented 11 years ago

@seanfisk Did you had a chance to have a look at this PR? I haven't updated the documentation yet (waiting for your feedback), but could do this in a next step.

seanfisk commented 11 years ago

Hi Ben, sorry, been busy the last couple days.

This is quite a bit of a hack but genius at the same time because it certainly works. There are a couple issues I see, which are not necessarily the direct result of this PR...

The root of the issue is that there are a lot of marginally overlapping tools from which we want specific features.

bitmensch commented 11 years ago

@seanfisk Thanks for your feedback. I'll try to address these issues and come up with an updated more cleaner (read DRY) solution. I already have some ideas how to get this solved.

bitmensch commented 11 years ago

@seanfisk Incorporated all your feedback in separated commits. Please review.

seanfisk commented 11 years ago

@benjixx At a glance, this looks really good, Ben. I will test today and, assuming no problems, should have it merged by the end of the day.

seanfisk commented 11 years ago

@benjixx Actually, it looks like I won't be able to do it today. I will try to have it merged tomorrow night or Monday morning.

seanfisk commented 11 years ago

This is very good. Thanks for the PR, Ben.

seanfisk commented 11 years ago

@benjixx This tests documentation generation, too, correct?

bitmensch commented 11 years ago

Yes, that's correct. I have seen something like this in the tox examples and thought it would be a good addition to our current tests as documentation generation is something that could fail too.

seanfisk commented 11 years ago

That's definitely a good addition. I was also pleasantly surprised by the Travis-CI output, although it is a bit confusing to see 2.7 as the version for all jobs in the matrix. Luckily the tox environment variable is also listed. Not much can be done there, though. Too bad Travis-CI doesn't support tox directly as it does RVM for Ruby.