search

seanharr11 / etlalchemy

Extract, Transform, Load: Any SQL Database in 4 lines of Code.
MIT License
555 stars 83 forks source link

Changes to __init__.py and literal_value_generator.py #2

Closed TBusen closed 8 years ago

TBusen commented 8 years ago

I am now able to import this using python 3.5. I changed the reference to cStringIO and StringIO to io, and removed the from statement in init.py to only reference the module and not the specific class

seanharr11 commented 8 years ago

Just need to test backwards compatibility of these changes. Great catch though, I haven't tested on anything > Python 2.7. Give me 24 hours...

seanharr11 commented 8 years ago

This is a much larger issue: the issue of supporting Python 3.5. I will create a branch for this task, and set up some testing to facilitate this migration. (We need to maintain backwards compatibility w/ 2.7 and prevent regression).

seanharr11 commented 8 years ago

@travBoog I've created a branch for Python 3.5 support here

I've made some changes based on your feedback, and both problems (importing module issues & CStringIO Deprecation) have been addressed.

There are still a number of other issues with the branch not allowing functionality on python 3.5, like changes to list comprehensions (map, filter, etc...) that haven't been accounted for in this project. Please checkout this new branch, and open all future pull requests regarding python 3.5 support there!

Lastly, we need to prevent regression concerning python 2.7, so I will work on building some unit tests to allow us to test, and merge this branch back into master when we are confident it supports both 2.7 & 3.5.

Feel free to reach out to me via email: seanharr11@gmail.com