search

seanhess / hyperbole

Haskell interactive serverside web framework inspired by HTMX
Other
95 stars 6 forks source link

Don't add duplicate CSS rules #10

Closed kfigiela closed 5 months ago

kfigiela commented 5 months ago

As discussed in #9, there are some glitches related to polling and CSS handling. Essentially, hyperbole will add all CSS rules it gets from hyper view whenever hyper is reloaded. When polling this causes CSS rules list to grow indefinitely. I wonder if that could cause performance issues for long running app? Furthermore, this made dev-tools overrides virtually impossible due to constant updates. To summarize the issue is best described with a video:

b33b5e4a-c464-4973-b691-e797e1da3943

In this PR I attempt to address the issue, by ensuring hyperbole will not add the same rule twice. This deduplicates on what would be added, not necessarily on what is currently in the stylesheet, allowing for local overrides.

seanhess commented 5 months ago

Love it!

Interesting that you could use it to specify local overrides. I think it would make more sense to override it by creating new definitions in Haskell. You're still leaning towards the traditional method of customization by swapping out stylesheets instead of using your programming language to redefine styles (and getting all the type-checking goodness). web-view is a full departure from that method of reuse.

kfigiela commented 5 months ago

I use local overrides in dev-tools for experimentation. Feedback loop is instant, which cannot be said to styles encoded in Haskell. The whole recompile and restart cycle is just not efficient.

seanhess commented 5 months ago

Ah, thanks for explaining!