search

seankenny / fullcalendar

Full-sized drag & drop event calendar (jQuery plugin)
http://arshaw.com/fullcalendar/
MIT License
60 stars 39 forks source link

Adds resourceFilter option #23

Closed zvictor closed 10 years ago

zvictor commented 10 years ago

Please check demos/resource-views.html. Does not need more explanation = )

seankenny commented 10 years ago

I like this one :) There was a request some time back to allow a hook to filter resources as a user moved forwards/back throught he dates. This works perfectly for that.

One small issue - uncheck all the resources in the demo page and there is a js undefined exception. Not too sure how we would cater for no resources returned by a filter?

zvictor commented 10 years ago

I think it makes sense to behave in the same way it behaves when there are no events. If I remember well, it renders the entire calendar and its days normally and just does not render the events. I am gonna spend some minutes now trying to get the same here.

zvictor commented 10 years ago

Given two scenarios: 1 - Day view without any event; 2 - Resource view without any resource.

When calling setHeight on both scenarios we have an inconsistency on this part of the code:

dayBodyFirstCellStretcher
            .height(bodyHeight - vsides(dayBodyFirstCell));

On scenario 1, dayBodyFirstCell points to the first empty event slot, while in scenario 2 it is undefined.

It does not seem to be a bug caused by this PR, but a bug that was already hidden there.

seankenny commented 10 years ago

Yes I agree it is appears to be an existing bug. Let's add your change and I'll raise an issue on it.

On 19 August 2014 09:42, zVictor notifications@github.com wrote:

Given two scenarios: 1 - Day view without any event; 2 - Resource view without any resource.

When calling setHeight on both scenarios we have an inconsistency on this part of the code:

dayBodyFirstCellStretcher .height(bodyHeight - vsides(dayBodyFirstCell));

On scenario 1, dayBodyFirstCell points to the first empty event slot, while in scenario 2 it is undefined.

It does not seem to be a bug caused by this PR, but a bug that was already hidden there.

— Reply to this email directly or view it on GitHub https://github.com/seankenny/fullcalendar/pull/23#issuecomment-52605430.