search

seankenny / fullcalendar

Full-sized drag & drop event calendar (jQuery plugin)
http://arshaw.com/fullcalendar/
MIT License
60 stars 39 forks source link

Any plans to move to v2.1.1 #42

Open jsgoupil opened 9 years ago

jsgoupil commented 9 years ago

There are some nice functionality of drag-n-drop in that version that I would benefit. Like dragging an event outside the calendar. Do you have any plans to get this done? Since it's your repo, it makes more sense if you do it since you know the file system better.

seankenny commented 9 years ago

https://github.com/seankenny/fullcalendar/tree/master

jsgoupil commented 9 years ago

I was looking into this and yeah... I was like "wait a minute, git merge main/master >> Already up-to-date." OK. So what is the v2 branch then? I fixed some bugs in that one, do you merge back in master?

seankenny commented 9 years ago

v2.1.1 is so different from the previous version I was not able to update so needed to start from scratch. Joys of forking I suppose.

V2 is v2. Master is the latest.

Haven't been spending much time on this. Working on gantt calendar view instead.

seankenny commented 9 years ago

Will "merge" this into master over the weekend.

jsgoupil commented 9 years ago

Thank you so much, I have tried my app with master. And other than the bug I fixed (resources being integer), I can't drag events between resources. I'm sure you fixed a lot of bugs in v2 and hopefully it will just work when you merge :) Let me know and I will be happy to test it out.

seankenny commented 9 years ago

Done and referenced to #39. I am not yet using the master branch. I've given it some shakedown testing and it looks pretty OK as have a few other users. Buyer beware though! Let me know if you spot issues. Like I said, there is a huge difference between v2 and this version. The original fork should really have major version changed given then differences but there you go.

jsgoupil commented 9 years ago

Hey Sean, thanks for porting this over. But I meant that other than that bug, the calendar is just not functional.

For instance, you have a new method called "rangeToSegs", and this one is being called by highlightSkeletonHtml which does not have a 3rd argument with resourceIds. (repro with selectable: true)

Events are not draggable between resources, etc.

I'm not sure those kind of bugs happened in your v2.

seankenny commented 9 years ago

Like I said, the code base is totally changed. There will obviously be a lot of issues until I can get to them. Converting to this branch took weeks to do so was not trivial.

Funny you are saying it is unusable though. There are a few guys happy enough with it as it stands. Maybe raise some issues or PRs? I thought the drag drop was working with ok.

I won't be spending much time on this for a few weeks as I am looking at a gantt calendar spike for a while.

On 17 Oct 2014, at 19:38, Jean-Sébastien Goupil notifications@github.com wrote:

Hey Sean, thanks for porting this over. But I meant that other than that bug, the calendar is just not functional.

For instance, you have a new method called "rangeToSegs", and this one is being called by highlightSkeletonHtml which does not have a 3rd argument with resourceIds. (repro with selectable: true)

Events are not draggable between resources, etc.

I'm not sure those kind of bugs happened in your v2.

— Reply to this email directly or view it on GitHub.

jsgoupil commented 9 years ago

I'll see what I can do over the weekend on this. I am new to Travis thingy and I think you have it setup for this project (I don't know if its setup for master?). It seems to be using Jade or Pavlov style. I'll just need to figure out how to run them, maybe they are all in Grunt.

scopendo commented 9 years ago

Any further feedback from others on the stability of v2.1.1 in master? Is it recommended over the v2 branch for live use?

rasmuschristensen commented 9 years ago

I just switched from V2 to master. had issues resizing and dragging in V2. Now as I'm dynamically adding/removing resource, this worked just fine in V2 using the render function after changes, this is now broken for some reason in master. Really not sure what to do....