seankongery / homework-assignment-3

0 stars 0 forks source link

Feedback on assignment 3 #1

Open barryross opened 7 years ago

barryross commented 7 years ago

FEWD Week #3 Project: Multi-Column layout


Description

Student: Sean Bacastow

Project URL: https://github.com/seankongery/homework-assignment-3

Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use either a normalize.css or reset.css (see links in class resources from Unit 3) x
Use CSS grid to achieve a 3-column layout x
Use proper filename conventions (lowercase, .html) x
Use a single external CSS stylesheet to style all pages (add onto the one you used for the landing page) x
Use at least 4 relevant semantic HTML5 elements (nav,header, article,footer etc.) x
Use CSS Flexbox to layout the contents of at least one structural component (e.g. logo and navbar within <header>) x
Add a hover effect to the navigation links in the sidebar using pseudo-classes x
TOTAL: 12/14
barryross commented 7 years ago

Sean, great work on this assignment! You have done a great job hitting the technical requirements! It looks like things are starting to click for you for flex..feeling better about it?

seankongery commented 7 years ago

Hey Barry, thanks for the feedback. The flex is definitely starting to come more naturally. I think at this point, when I have a problem with flex, it's more of an issue with something overriding the flex attribute I'm using, or me tagging something improperly. With more reps, and a better feel for how code should be written, I'm sure those things will sort themselves out.

barryross commented 7 years ago

Hey Sean,

You're welcome for the feedback and thanks for your response. Glad you are feeling better with it overall, and I think you're totally right about those things shorting themselves out as you continue with the reps and being exposed to more and more example code.