seankross / mario

🍄 But our princess is in another castle!
Other
21 stars 1 forks source link

output row labels (indices?) along with the data for each row #13

Closed pgbovine closed 2 years ago

pgbovine commented 2 years ago

I originally thought R's row labels were just numerical indices (1, 2, 3, 4, ... etc.) but it seems like some data frames have named indices, like mtcars. if that's the case, we should output the row labels as well, which makes the schema more consistent with what pandas outputs

> mtcars
                     mpg cyl  disp  hp drat    wt  qsec vs am gear carb
Mazda RX4           21.0   6 160.0 110 3.90 2.620 16.46  0  1    4    4
Mazda RX4 Wag       21.0   6 160.0 110 3.90 2.875 17.02  0  1    4    4
Datsun 710          22.8   4 108.0  93 3.85 2.320 18.61  1  1    4    1
Hornet 4 Drive      21.4   6 258.0 110 3.08 3.215 19.44  1  0    3    1
Hornet Sportabout   18.7   8 360.0 175 3.15 3.440 17.02  0  0    3    2
Valiant             18.1   6 225.0 105 2.76 3.460 20.22  1  0    3    1
Duster 360          14.3   8 360.0 245 3.21 3.570 15.84  0  0    3    4
Merc 240D           24.4   4 146.7  62 3.69 3.190 20.00  1  0    4    2
Merc 230            22.8   4 140.8  95 3.92 3.150 22.90  1  0    4    2
Merc 280            19.2   6 167.6 123 3.92 3.440 18.30  1  0    4    4
...
seankross commented 2 years ago

In R this is bad pedagogy/ worst practice and therefore I do not want to support it. If row names are present the best practice is to use tibble::rownames_to_column().

pgbovine commented 2 years ago

cool sounds good, we can close