search

seankross / postcards

💌 Create simple, beautiful personal websites and landing pages using only R Markdown.
Other
541 stars 87 forks source link

Create postcard #23

Closed seankross closed 3 years ago

jjallaire commented 3 years ago

We are hoping to update the distill docs with directions on how to include postcards. If you end up merging https://github.com/seankross/postcards/pull/20 then we'll just say "create a postcard via New R Markdown... document". Otherwise, we'll instruct people to use the create_postcard() function once this PR is merged. LMK what you have in mind and I'll update the docs accordingly.

seankross commented 3 years ago

You should instruct people to use create_postcard() and I am going to do the same in the postcards documentation. Thank you again for your contributions to this package and for supporting its use with distill, which is a package and project I admire very much. If you want to add yourself as a coauthor of this package feel free to send me a PR for the description file.

jjallaire commented 3 years ago

Great, thanks! Here are the updated docs on using postcards with distill: https://rstudio.github.io/distill/website.html#postcards

seankross commented 3 years ago

Looks great! Let me know if there are any other changes you would like to see before I send the updated version of this package to CRAN.

jjallaire commented 3 years ago

LGTM. @apreshill Any changes you'd want to see here?

apreshill commented 3 years ago

Sorry to chime in late- this looks great! The only thing I've noticed in testing is that the background gradient for onofre doesn't seem to transfer within a distill site. Maybe something here isn't translating- it looks like in my debugger that $color1$ isn't found, but that is as far as I got!

https://github.com/seankross/postcards/blob/f7e0d4cb5bff0435a633ae6d497464d197acb133/inst/pandoc_templates/onofre.html#L8-L19