Hey, I am looking for a bit of feedback, before sending in a pull request.
The "inspired by" line is a bit weird.
When only a sourceName is defined, then it looks fine: "inspired by Name of Source"
When both a sourceName and authorName, then it becomes bit weird: "inspired by Name of Source from Author Name"
When only a authorName is defined, then it is a invalid sentence: "inspired from Author Name"
I want to create a pull request for "Inspired by Name of Source. Written by Author Name.". This makes the variations easy (the whole thing or only one of the pieces) and translations are easy.
I am not a native English speaker, so suggestions for the text are welcome.
I'm not a native speaker myself, but I agree, that your solution is way better. For that reason I would suggest to go for it, unless someone intervenes ;-)
Hey, I am looking for a bit of feedback, before sending in a pull request.
The "inspired by" line is a bit weird.
sourceName
is defined, then it looks fine: "inspired by Name of Source"sourceName
andauthorName
, then it becomes bit weird: "inspired by Name of Source from Author Name"authorName
is defined, then it is a invalid sentence: "inspired from Author Name"I want to create a pull request for "Inspired by Name of Source. Written by Author Name.". This makes the variations easy (the whole thing or only one of the pieces) and translations are easy.
I am not a native English speaker, so suggestions for the text are welcome.