search

seanliang / HighlightWords

A Sublime Text 2 & 3 plugin for highlighting mutiple words in different colors
https://github.com/seanliang/HighlightWords
58 stars 21 forks source link

Still maintained? #31

Closed emanuelen5 closed 5 years ago

emanuelen5 commented 5 years ago

I am developing a plugin with almost identical feature set Word-highlighter (name subject to change) and wanted to publish my package on Package Control and therefore issued a pull request. However, the maintainers quickly noted that my package is eerily similar to yours.

They therefore suggested that I should reach out to you and see if you are still maintaining this package, as well if you accept pull requests. I however do not feel like taking your package and turning it into mine since that would require a lot of work for me (writing test cases all over etc.).

Do you feel like our plugins are too similar to coexist on PC (don't consider the name - it will change before being published on PC)?

xacid commented 5 years ago

I am not the owner but was an contributor. I installed Word-highlighter and played around a bit. Some comments:

  1. Good see the color palette is configurable through the file (that has been long-requested here). It will be even better if the file is accessible from the menu.
  2. "Edit highlight color" doesn't work for some color schemes.
  3. I personally feel the keys are too long. Using the menu to edit it, I got "error: The settings file "res://Packages/word_highlighter/Controls/Default (Windows).sublime-keymap" could not be opened".
emanuelen5 commented 5 years ago

Hi, thanks for the comments.

  1. Sure, I can add the scheme template to the menu.
  2. This is hard to investigate without more details.
  3. Fixed the error and added test cases for it.

You’re welcome to submit issues to the Github page if you have any more comments or suggestions.

seanliang commented 5 years ago

@emanuelen5 Sorry for the late response. I've invite you as a collaborator, please feel free to make your changes.

emanuelen5 commented 5 years ago

Sure, I can be a collaborator. However, I do not think our plugins are similar enough to be completely merged. Also, adding coverage testing etc. would be too much work for me.