ReconVirus
commented
4 months ago I havent tested this out myself but a solution might be update
getStatusBarText = async ( workspace: Workspace ): Promise<string | null> => {
const file = workspace.getActiveViewOfType( MarkdownView )?.file
if ( !file ) {
return null
}
const { totalEvents } = await getNumEventsInFile({ file, appVault: this.appVault, fileCache: this.metadataCache }, null )
switch ( totalEvents ) {
case 0:
return 'Timeline: No events'
case 1:
return 'Timeline: 1 event'
default:
return `Timeline: ${totalEvents} events`
}
}
}to split the line into two parts:
const activeView = workspace.getActiveViewOfType( MarkdownView );
if ( !activeView ) {
return null;
}
const file = activeView.file;This way, you’re not trying to access the file property until after you’ve checked that activeView is not null or undefined.
seanlowe
Shred99
Korolebi
Summary: Consistently every time I open Obsidian for the first time in a session the plug-in does not show timelines in Reader mode. Events are marked as events still, and changes to the CSS file still are passed to the Event Notes
Additional Information: ob-timeline-flat and ob-timeline code block for timeline creator both follow this pattern, however changes made to CSS related to events and the event counter in the property still do work on startup without reloading the plugin. The only issue is the graph themselves. Work around listed below works consistently.
Steps to reproduce: 1.) Close Obsidian 2.) Re-open Obsidian 3.) Observe the lack of timeline Expected Result: I see a timeline in Reader mode Actual Result: Notes with timelines are blank Reproducible: Always. Work Around: 1.) Disable Timeline plug-in in Obsidian Settings 2.) Re-enable Timeline plug-in in Obsidian Settings Severity/Priority: Minor, Low. However, new users who run into similar issues may assume the plugin doesn't work at all so I'm hesitant to say Trivial Additional Plug-ins used: Too many to list, however none performing actions in target folder Plug-in Version: 1.2.0 System/Set-up: Windows 11, Version 10.0.22621 Build 22621. Only tested Desktop. Minimal Theme. Timelines and Events are all located in the same subfolder of the vault with no other notes. Event and Timeline notes have no extra css classes beyond those required for plug-in use
Console: On start up TypeError is thrown ->