Closed seanlowe closed 2 weeks ago
@enigmartyr, when you have some time, please go through buildVerticalTimeline
and push up some commits to rename some variables with variable names that are more clear. If you could adjust some code to adhere to the eslint code style rules, I would appreciate that too but if not I can always fix that myself when I have some time.
Thanks!
Screenshots:
Continued from PR #55
v2.2.0
Implement Issue:
Feature suggestion, time spans in vertical timelines
#52: Added support for time spanning events in vertical timelinesHUGE Shoutout to enigmartyr who did a lot of the heavy lifting for this feature!
Changes:
buildVerticalTimeline()
endDate
to default to the same as start date rather than nullinsertTimelineIntoCurrentNote
tocommands.ts
handleColor
tocolors.ts
and removedhandleDynamicColor
as an export (no longer needed)buildVerticalTimeline
to new filetimelines/vertical.ts
buildHorizontalTimeline
to new filetimelines/horizontal.ts
showEmptyTimelineMessage
to new filetimelines/index.ts
TimelineCommandProcessor
constructor to accept a new param that enablesinsertTimelineIntoCurrentNote
to run correctlyDOM.Iterable
totsconfig.json
NoteData
type intoAllNotesData
HTMLDivElement & { calcLength?: () => void }
from vertical.ts into typeDivWithCalcFunc
and replaced referencesdeveloperSettings
into constants.ts and renamed toDEVELOPER_SETTINGS
. Replaced all referencesvertical-timeline.scss
This release: