seanmccarty / RequestedRolls

1 stars 5 forks source link

Draggable dice #35

Closed seanmccarty closed 1 year ago

seanmccarty commented 2 years ago

Discussed in https://github.com/seanmccarty/RequestedRolls/discussions/34

Originally posted by **ClarinetK622** June 29, 2022 Hey Sean, Great work with this extension! I wouldn't run a table without it; members of my group don't want FGU's handy automation taking away their ability to make rolls themselves. While the extension is excellent, one challenge is that when the roll pops up, the only option is to click the button to throw virtual dice. A nice middle ground would be the option to click and drag dice into the chat box or dice tower (as a bonus it would enable hidden [SAVE VS] rolls). This would also be in service of what I believe this extension is designed to do, make for a more interactive experience at the virtual table. As such, I've gone ahead and forked your repo and implemented draggable dice. I think this could be a nice feature to incorporate into the core extension for others to enjoy, but I will leave that up to you, as the mastermind of the original code. Feel free to take a look and see what you think. There may be bugs, or things done suboptimally; this was my first time working with Lua and xml, let alone cracking open an FGU extension. The way I've implemented things does add a level of complexity which may lead to unintended extension conflicts, so I understand if you'd rather keep it as a separate fork. In any case, I thought I would provide you the option. If you'd like, I'm happy to chat about squashing bugs and revising the code into something more suitable for incorporation into the RequestedRolls package. https://github.com/ClarinetK622/RequestedRolls - Justin