Invisible Kerbals in Command Seats (xfering from cabins to seats, as well as when opting to loading Tourists after prompted by KSP after vessel launch)

inigmatus commented 8 years ago

http://forum.kerbalspaceprogram.com/threads/120740-1-0-5-Take-Command-Launch-Kerbals-in-External-Command-Seats-v1-2-1-Nov-14-2015?p=2314441&viewfull=1#post2314441

Bug report 1: transferring any Kerbal from a Crew Cabin or Cockpit to a Command Seat moves the Kerbal, but the Kerbal is rendered invisible in the chair until I transfer him back to a cockpit or crew cabin.

Bug report 2: spawning Kerbals after launch into Command Seats renders them also invisible in the seat (such as when you launch a plane with a pilot, but you have an active tourist contract), if you select to load the passengers after launch, the loaded passengers/tourists also fail to visibly appear in the Command Seats even though they are there when you click to transfer them to other places on the craft. If you pre-load the tourists in the seats while in SPH, they render fine on launch. This bug only happens if you launch a vessel initially without tourists, but then decide to load them only after you are asked by KSP if you want to load the tourists.

See related Contract Configurator issue #355: https://github.com/jrossignol/ContractConfigurator/issues/355

jrossignol commented 8 years ago

I should probably mention that passenger loading after launch (via dialog box) is Contract Configurator functionality. The relevant logic for how it is done is here, followed by this.

It should cause all the appropriate events to fire, although there's been one or two mods that have required fixes related to this (I think there was some problems or other with TAC-LS at one point).

seanmcdougall commented 8 years ago

Thanks for the bug reports. Please try out the new v1.3-beta I just posted to see if that fixes it.

inigmatus commented 8 years ago

I will test this tonight. Thanks.

inigmatus commented 8 years ago

Tested:

Transferring from cockpit to seat works now. No invisible Kerbal.
Loading tourists in seats works now too.

You can consider it a good production fix.

FYI, compatibility with Contract Configurator has been fixed in that the pop-up to load tourists after vessel load on launch pad also works to spawn kerbals, however and this may be a CC issue, the CC pop-up to load tourists only lasts for about 2 seconds - and after the first kerbal spawns the passenger load dialog is killed irrecoverably. A person only has about 2 seconds to decide to load passengers. I'll bring that up with nightingale.

jrossignol commented 8 years ago

Send logs. 😇

inigmatus commented 8 years ago

Logs:

C:/Users/Administrator/Downloads/KSP/KSP_win_DEV/KSP_Data/../saves/default/Ships/SPH/Auto-Saved Ship.craft [LOG 21:09:43.098] Game State Saved to saves/default/persistent [WRN 21:09:43.108] [HighLogic]: =========================== Scene Change : From EDITOR to FLIGHT (Async) ===================== [LOG 21:09:43.636] AddonLoader: Instantiating addon 'WiderContractsApp' from assembly 'WiderContractsApp' [WRN 21:09:44.539] ApplicationLauncher already exist, destroying this instance [LOG 21:09:44.543] QuickScroll(1.32): Settings Loaded [LOG 21:09:44.549] AddonLoader: Instantiating addon 'NavWaypoint' from assembly 'KSP' [LOG 21:09:44.552] AddonLoader: Instantiating addon 'NotInMyBackYard_Flight' from assembly 'NotInMyBackYard' [LOG 21:09:44.553] AddonLoader: Instantiating addon 'WiderContractsApp' from assembly 'WiderContractsApp' [LOG 21:09:44.577] ------------------- initializing flight mode... ------------------ [LOG 21:09:44.685] Loading ship from file: C:/Users/Administrator/Downloads/KSP/KSP_win_DEV/KSP_Data/../saves/default/Ships/SPH/Auto-Saved Ship.craft [WRN 21:09:44.701] [Part]: PartModule TransferDialogSpawner at seatExternalCmd, index 3: index exceeds module count as defined in cfg. Looking for TransferDialogSpawner in other indices... [WRN 21:09:44.702] ...no TransferDialogSpawner module found on part definition. Skipping... [WRN 21:09:44.707] [Part]: PartModule TransferDialogSpawner at seatExternalCmd, index 3: index exceeds module count as defined in cfg. Looking for TransferDialogSpawner in other indices... [WRN 21:09:44.708] ...no TransferDialogSpawner module found on part definition. Skipping... [WRN 21:09:44.714] [Part]: PartModule TransferDialogSpawner at seatExternalCmd, index 3: index exceeds module count as defined in cfg. Looking for TransferDialogSpawner in other indices... [WRN 21:09:44.715] ...no TransferDialogSpawner module found on part definition. Skipping... [WRN 21:09:44.721] [Part]: PartModule TransferDialogSpawner at seatExternalCmd, index 3: index exceeds module count as defined in cfg. Looking for TransferDialogSpawner in other indices... [WRN 21:09:44.722] ...no TransferDialogSpawner module found on part definition. Skipping... [WRN 21:09:44.728] [Part]: PartModule TransferDialogSpawner at seatExternalCmd, index 3: index exceeds module count as defined in cfg. Looking for TransferDialogSpawner in other indices... [WRN 21:09:44.728] ...no TransferDialogSpawner module found on part definition. Skipping... [WRN 21:09:44.734] [Part]: PartModule TransferDialogSpawner at seatExternalCmd, index 3: index exceeds module count as defined in cfg. Looking for TransferDialogSpawner in other indices... [WRN 21:09:44.735] ...no TransferDialogSpawner module found on part definition. Skipping... [LOG 21:09:44.736] arack loaded! [LOG 21:09:46.110] putting ship to ground: 9.67543 [LOG 21:09:46.113] [arack]: Ready to Launch - waiting to start physics... [LOG 21:09:46.117] Crewmember Jebediah Kerman assigned to EAS-1 External Command Seat, seat # 0 (crew seat index: 0) [LOG 21:09:46.118] [FLIGHT GLOBALS]: Switching To Vessel arack ---------------------- [LOG 21:09:46.120] setting new dominant body: Kerbin FlightGlobals.mainBody: Kerbin [LOG 21:09:46.121] Reference Frame: Rotating [LOG 21:09:46.129] stage manager resuming... [LOG 21:09:46.130] Vessel assembly complete! [LOG 21:09:46.130] stage manager starting... [LOG 21:09:46.130] all systems started [LOG 21:09:46.162] [TakeCommand] added escape hatch to seatExternalCmd (-325896) [LOG 21:09:46.164] [TakeCommand] added escape hatch to seatExternalCmd (-325944) [LOG 21:09:46.165] [TakeCommand] added escape hatch to seatExternalCmd (-325992) [LOG 21:09:46.166] [TakeCommand] added escape hatch to seatExternalCmd (-326040) [LOG 21:09:46.168] [TakeCommand] added escape hatch to seatExternalCmd (-326088) [LOG 21:09:46.169] [TakeCommand] added escape hatch to seatExternalCmd (-326136) [LOG 21:09:46.172] Reloaded override drag cube for zeroed cube root part trussPiece3x on vessel arack [LOG 21:09:46.273] [ScenarioDestructibles]: Loading... 0 objects registered [LOG 21:09:46.274] [ScenarioUpgradeableFacilities]: Loading... 0 objects registered [LOG 21:09:46.337] ContractConfiguratorSettings.OnLoad [LOG 21:09:46.365] Loading Depletion Nodes [LOG 21:09:46.365] DepNodeCount: 0 [LOG 21:09:46.365] Loading Biome Nodes [LOG 21:09:46.366] BiomeNodeCount: 0 [LOG 21:09:46.366] Loading Planet Nodes [LOG 21:09:46.366] PlanetNodeCount: 0 [LOG 21:09:48.690] [FlightIntegrator]: Vessel arack has been unloaded 1.79769313486232E+308, applying analytic temperature 314.680154863555 [LOG 21:09:48.696] [DEBUG] ContractConfigurator.ConfiguredContract: Initializing contract: CONTRACT_TYPE [SSI-Give-batteryPack] [LOG 21:09:48.793] [PlanetariumCamera]: Focus: arack [LOG 21:09:48.991] Flight State Captured [LOG 21:09:48.994] Saving Achievements Tree... [LOG 21:09:48.994] Saving Achievements Tree... [LOG 21:09:49.067] Game State Saved as persistent [LOG 21:09:50.100] [arack]: ground contact! - error: -0.102m [LOG 21:09:50.102] Unpacking arack

jrossignol commented 8 years ago

wasn't much useful - was there nothing after that (you said that it took 2 seconds for the dialog to disappear).

inigmatus commented 8 years ago

I know... I can't explain it. Let me link the contract Im using and test craft.

inigmatus commented 8 years ago

nightingale, here is the bug testing pack: http://www.mediafire.com/download/j9i18la5iik8yea/BugTesting_TC1.zip

Issue 1: instructions: look for Bug Test contract, accept, go to SPH, load craft, put Jeb in the front seat, launch. Wait about 6 seconds. Dialog to load passengers pops up, jeb loads, then dialog disappears.

Issue 2: If you click to load passengers, they do load fine. To complete the contract you must unload all five passengers, and then recover the pilot with the craft. Doing so recovers the pilot and craft, but all five passengers remain (hence why I think we need a RemoveKerbal).

seanmcdougall / TakeCommand

Invisible Kerbals in Command Seats (xfering from cabins to seats, as well as when opting to loading Tourists after prompted by KSP after vessel launch) #1