Closed ameliabradley closed 2 years ago
Hey, thanks for making these fixes! It looks like some of the things clippy suggests to do can't be done without requiring a newer rustc
version. Hence, the Minimum Supported Rust Version (MSRV) test fails.
@seanmonstar Ah, I didn't see the minimum supported Rust version. That makes sense. Updated the changes to tell clippy to ignore those lines. Let me know if you'd like this addressed in some other manner.
This is just my personal preference, but I prefer that code doesn't include attributes mentioning clippy. The rest of the cleanups look great, though!
@seanmonstar Cool! I've removed the clippy attributes.
For reference, this was the clippy output: