seanmonstar / httparse

A push parser for the HTTP 1.x protocol in Rust.
https://docs.rs/httparse
Apache License 2.0
569 stars 110 forks source link

Switch benches to criterion and remove pico targets #112

Closed acfoltzer closed 2 years ago

acfoltzer commented 2 years ago

Criterion allows us to crank up the sampling size and confidence, which is important for these kinds of microbenchmarks that can have high variance. It also has other bells and whistles like tracking relative performance between runs, which can be very helpful for development, and no longer requires a nightly compiler to run the benchmarks.

Per discussion in Discord, the presence of pico in these benchmarks has outlived its usefulness; we're now primarily concerned with the relative performance of httparse between changes.

seanmonstar commented 2 years ago

Awesome stuff, thank you! <3