refactor: cleaner header parsing

seanmonstar / httparse

A push parser for the HTTP 1.x protocol in Rust.

https://docs.rs/httparse

Apache License 2.0

567 stars 111 forks source link

refactor: cleaner header parsing #139

Open AaronO opened 1 year ago

AaronO commented 1 year ago

Builds off #134 (swar), #138 (Bytes cursor)

Cleaner, faster and less macros !

Key changes

Broke down header-parsing into clean conceptual steps (whilst being faster !)
Added InnerResult allowing for idiomatic ? early-exits, removing need for parsing-helper macros
Removed macros.rs, leaving only byte_map! (response header-parsing macros should become functions)

TODO

[ ] convert response header-parser, supporting its quirks

seanmonstar commented 1 year ago

Happy to see those gnarly macros cleaned up. I put those together when I was very new at Rust, and slowly grew them poorly, and understanding them whenever I came back to them was always confusing.

I'm guessing moving around the enums makes them slightly smaller. You said there was a measurable perf improvement?

seanmonstar commented 10 months ago

Just checking in here, did you want to get this merged before we shoot out the new release?