search

seanmonstar / intel

I need more intel!
http://seanmonstar.github.io/intel/
Mozilla Public License 2.0
202 stars 26 forks source link

fix rotating file handler write lock #13

Closed chopachom closed 11 years ago

chopachom commented 11 years ago

This commit fixes a bug when RotatingFileHandler was always writing only one log record to the file if it had already wrote a record before the new one came in. This was caused by not setting write flag to false if the buffer is empty.

coveralls commented 11 years ago

Coverage Status

Coverage remained the same when pulling cfdf53480746e328dade3dd5d16edf822735ef41 on chopachom:master into 339ef0fe287c2b89c4387e4179c24aeea345fdc9 on seanmonstar:master.

seanmonstar commented 11 years ago

Thanks! Would you be able to add a test where this previously failed, and with your fix, now works?

coveralls commented 11 years ago

Coverage Status

Coverage remained the same when pulling 63e0257628334bf9d8bcdd5af4fc2ea6393b8c17 on chopachom:master into 339ef0fe287c2b89c4387e4179c24aeea345fdc9 on seanmonstar:master.

chopachom commented 11 years ago

Sure!

seanmonstar commented 11 years ago

Nice! I'll publish the fix when I get back to a computer.