seanmonstar / num_cpus

Get the number of CPUs in Rust
Apache License 2.0
582 stars 91 forks source link

Miscellaneous updates #111

Open lrazovic opened 3 years ago

lrazovic commented 3 years ago

I understand that it's a lot of changes, and especially for those that increase the level, I'm ready to discuss its implementation and in case go back.

I tested this PR on Linux and Windows, using cargo test --all-features --all-targets, miri and clippy.

vilgotf commented 3 years ago
  • Update libc to latest version.

This just disallows older libc versions for no reason. The latest libc version is already allowed (libraries don't generally specify max versions in rust, the specific version is decided by applications in Cargo.lock)

lrazovic commented 3 years ago

Thank you so much for the explanation, now I learned something new. I removed the dependency updates from the PR.

seanmonstar commented 3 years ago

Sorry for missing this 🙈

The dependency change is a good catch, we should stay conservative. Also, any changes that increase the MSRV should probably only be done because of a huge improvement. With such a basic, fundamental crate, we don't want to make it so people couldn't upgrade (even if they are using some ancient compiler).