Tracking issue for libz blitz evaluation of reqwest

[dtolnay]

This is the tracking issue for the evaluation performed by the libs team this week.

• [x] Expose RedirectAttempt and RedirectAction types
• [x] Hide trait impls that are inaccessible to users
• [x] Send and Sync in return type of Error::get_ref
• [x] Switch to &mut self builder
• [x] Move try_ macro to error.rs
• [x] Use realistic error handling in example code
• [x] Include an "Errors" section in documentation of functions that can return error
• [x] Decide how to handle JSON serialization errors
• [x] Comment why unwrap() won't fail
• [x] Include html_root_url attribute
• [x] Response doc improvements
• [x] Examples for the Body constructors
• [x] Error doc improvements
• [x] Example for RequestBuilder::headers
• [x] Examples for RequestBuilder::body
• [x] Conform to the recommended pattern for sealed traits
• [ ] Reimplement StatusCode using associated constants
• [ ] Reimplement Method using associated constants
• Stabilize some of the foundational types in a separate crate

[theduke]

I don't know if this was discussed in the meeting, but what are your thoughts regarding hyper async and stabilizing request?

Should 1.0 wait for a stable release of hyper async?

Or should there already be a SyncClient with a backwards compatible API once hyper async arrives?

[seanmonstar]

It was mentioned that since an async client will need to expose Future, and the futures crate won't stabilize before reqwest, then reqwest 1.0 will just have a sync client, and and reqwest_async will live seperately as an unstable thing. When it can stabilize, it could be merged into reqwest and released as v2.0.

[seanmonstar]

That said, to reduce breakage of reqest v1 -> v2, the Client naming issue is relevant here.

[little-dude]

Lots of these issues are doc or examples. I'm thinking about writing examples using https://httpbin.org. Would that be good, or did you have other ideas in mind?

[seanmonstar]

It's fine for the example to refer to httpbin, just because the example isn't in a fn main() {}, so we don't have the doctests actually making requests.

[budziq]

Hi large part of docs (including part of landing page) are missing links when referencing symbols. Should these be corrected (assuming yes from log crate evaluation)?

[brson]

1196 was superceded by the existing https://github.com/hyperium/hyper/issues/894 issue, which still needs to be fixed before reqwest 1.0