search

seanmonstar / warp

A super-easy, composable, web server framework for warp speeds.
https://seanmonstar.com/post/176530511587/warp
MIT License
9.33k stars 709 forks source link

Upgrade to hyper v1 #1088

Open urkle opened 5 months ago

urkle commented 5 months ago

Now that hyper 1.0 is out we should upgrade warp to use the new version of hyper.

I have attempted locally to perform this update and there are a number of items that need to be reworked due to the removal of many high-level items from hyper.

How do you want to approach a PR upgrading Hyper? e.g. I can push up what I have so far and we can work through the compile errors.

urkle commented 5 months ago

@seanmonstar I have an in-progress PR #1090 .

There are a few issues though.

One big one is figuring out what the Response type should be. e.g. should it be a Response? (the new name for the old Body struct). or should it be some type of BxBody?

The issue I had with BxBodyempty was even with that I couldn't coerce a http_body_util::Empty has a different error class (Infallible) over the error type for the Incoming strict, thus using http_body_util::Empty in place of Incoming::empty() does not work with that.

Then there is the whole gutting of the server and stream stuff out of Hyper that will need to be rewritten/replaced.

kimhanbeom commented 2 months ago

@urkle @seanmonstar Does warp currently have any plans for hyper 1.x?

seanmonstar commented 2 months ago

I make occasional progress as time allows, though many my users and client direct my attention elsewhere.

urkle commented 2 months ago

@seanmonstar if you can find some time to look at my PR and provide suggestions/feedback on the items I posted there that would be helpful so I can move forward on that PR

czy-29 commented 1 month ago

Upgrading hyper to v1 can also close this issue: https://github.com/seanmonstar/warp/issues/1100