search

seanmor5 / genex

Genetic Algorithms in Elixir!
Apache License 2.0
144 stars 13 forks source link

A bit of tidying up on Knapsack #18

Closed dokie closed 5 years ago

dokie commented 5 years ago

I tries to tidy the Knapsack example and as I use VS Code, I also added a .gitignore entry for it. Also my VS Code setup runs dialyzer automatically so I fixed up only one @spec that was causing a warning.

seanmor5 commented 5 years ago

Hey, this looks great! One thing of note, the old style of configuration (configuring the algorithm in the module rather than providing configuration options to run) will be unsupported in the next version of Genex. I'll likely go in and remove that from the example when support completely goes to the wayside. One other thing: there's currently a bug in the bit_flip mutation implementation, so if you get any weird results that's why.

Sorry for any issues you had to work through in getting this example up. I appreciate the contribution!