seanmturley / natureddit

A simple Reddit client, featuring a landing page dedicated to nature with posts pulled from a curated list of subreddits.
0 stars 1 forks source link

Aesthetic improvements #152

Closed seanmturley closed 7 months ago

seanmturley commented 8 months ago

Description

A number of small aesthetic improves would greatly improve the polish of this project, making it more presentable as part of my portfolio.

Tasks

seanmturley commented 7 months ago

Added "share" icons to Comment via the new ShareButton component created in #157.

seanmturley commented 7 months ago

Added "score" icon to Comment via the new ScoreDisplay component created in #158.

seanmturley commented 7 months ago

Added the menu icon. It looks pretty good as is, but may want to to adjust the size and play with variant options (from both Phosphor Icons and Iconicons 5).

seanmturley commented 7 months ago

Added non-theme icons to DropdownMenu - the theme related icons are inside ToggleSwitch, which will be a little more complicated.

The icons look good, but the vertical centering may need some finessing - simply adding flex align-items: center isn't doing a great job due to the way the text sits.

seanmturley commented 7 months ago

Added the magnifying glass icon to SearchBar. Also need to add the "x" symbol for the clear search, but this is currently an input with value="x", so I need to think about how to insert the icon in there while maintaining accessibility.

seanmturley commented 7 months ago

For the clear search button I changed it from an <input> to a <button> so that it could take the icon as a child element.

seanmturley commented 7 months ago

Replaced IoLogoReddit in DropdownMenu with PiRedditLogo. The former had noticeably thinner line weight than the other icons in DropdownMenu (even though they were from the same icon library). This is also now consistent with the Reddit icon used in Comment.

seanmturley commented 7 months ago

Closing as complete (though there's bound to be some issues crop up, not to mention mobile view).