Questions/comments regarding the comments

seannam1218 / Todo-List-Project

Simple project

1 stars 0 forks source link

Questions/comments regarding the comments #4

Open seannam1218 opened 7 years ago

seannam1218 commented 7 years ago

I lost your comments by approving the pull request :( I'll base my questions/comments on what I can remember.

seannam1218 commented 7 years ago

I can see I have inconsistent spacing in my js file, but my css file has consistent 4-space spacing in my Note++. I think gitHub changes the format for some reason. Will keep an eye out for this in the future.

seannam1218 commented 7 years ago

Trailing white spaces noted. Could you remind me which softwares you recommended to remove these?

seannam1218 commented 7 years ago

When I made the icon object, I was considering additional features I could implement in the future. Like an "edit text" button, for example, or "add sub-items" button. These would require different img links, hence the link is passed in the parameter. Was this a bad choice?

seannam1218 commented 7 years ago

Is it possible to use less "manual html surgeries" using JavaScript default library or JQuery? I can't find my way around it with the tools that I learned. I get that using React would enable you to avoid using manual html surgeries though.

seannam1218 commented 7 years ago

I just realized you can't comment on a comment on this section... is this how you would normally communicate with teammates or is there a better way to communicate?