search

seanngja / pe

0 stars 0 forks source link

File upload from txt not working with absolute file path as indicated in UG #5

Open seanngja opened 3 days ago

seanngja commented 3 days ago

{44BBDEE2-E3ED-43A3-BC8D-0C58B767F1E5}.png

This is without making any attempts to modify the txt file.

soc-se-bot commented 14 hours ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thanks for raising this issue. This is actually the expected behavior. File parsed in and file generated from the program are entirely different. Tester seem to stick with the idea of iP where data generated through the program will be saved and allowed to be pass through the program again (Closed Loop System). However, as mentioned at the start of the UG under Pre-Usage Guidelines, the allocation results file is NOT meant to be re-inputted into the program. The program is designed to have one input and one output where the output cannot be used as input (Open Loop System). The UG also provided some examples on what are the accepted file types and format and even provided test files for the users to experiment with. Our team believes that we handled this misuse case appropriately by prompting the error sufficiently to the user and allowing them to continue using the program.

image.png

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

uploading a csv file that was generated by the program fails to load without editing

image.png

below is the csv file without editing

image.png

[original: nus-cs2113-AY2425S1/pe-interim#290] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for raising this issue. This is actually the expected behavior. File parsed in and file generated from the program are entirely different. Tester seem to stick with the idea of iP where data generated through the program will be saved and allowed to be pass through the program again (Closed Loop System). However, as mentioned at the start of the UG under Pre-Usage Guidelines, the allocation results file is NOT meant to be re-inputted into the program. The program is designed to have one input and one output where the output cannot be used as input (Open Loop System). The UG also provided some examples on what are the accepted file types and format and even provided test files for the users to experiment with. Our team believes that we handled this misuse case appropriately by prompting the error sufficiently to the user and allowing them to continue using the program.

image.png

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]

## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]