search

seannzx / pe

0 stars 0 forks source link

Able to add a person into both patient and doctor #10

Open seannzx opened 2 years ago

seannzx commented 2 years ago

Steps:

  1. add n/Patient1 hp/123456 eml/sean@example.com a/1 street dob/28/02/2021
  2. toggle
  3. add n/Patient1 hp/123456 eml/sean@example.com a/1 street dob/28/02/2021

Not sure if this is intended but the person can be both a doctor and a patient?

patient1.PNG

patient12.PNG

nus-se-script commented 2 years ago

Team's Response

Yes this is intended. A person can indeed be a patient and a doctor at the same time. We want to separate the records to ensure that the information pertaining to their separate roles are preserved and displayed.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: So if I were to edit that person, I would have to first

  1. edit his patient field
  2. toggle
  3. edit his doctor field

seems kind of unintuitive and very time consuming? If you intended for a person to be both a patient and a doctor, there should be a command implemented to simplify this process (both gets edited in 1 shot), or the existing commands should be able to handle the case.

If this behaviour is truly intended, the revised severity should be medium because this is a flaw which causes occasional inconvenience to the receptionists, but they can still use the product. The receptionist has to know the exact

  1. Patient index
  2. Doctor index
  3. Edit both states with the SAME INFO to accurately reflect any change in details to enforce the fact that the both the doctor/patient are a single entity

which will definitely cause frustration for the user.

I initially graded it as low as I was unsure if this was intended from the developers or it was just a bug (it it was not intended, low would be adequate as I followed the advice to choose the lower severity). As the developers have confirmed that a person can be both a doctor/patient, it makes more sense for the revised severity to be medium. The current features (commands) that they have implemented are unable to optimally support this case where the person can be both a doctor & patient, given that all the commands work based on the CURRENT STATE of the app (to either handle patients or doctors, but never both). They lack the features that properly equips users to handle such cases, potentially causing user experience to feel sluggish, given that users have to do extra work to ensure that the records are accurate for both states.