search

seanpdoyle / ember-cli-rails-deploy-redis

Lightning Fast Deploys with ember-cli-rails
MIT License
10 stars 7 forks source link

Should `deploy_key` also be prefixed with namespace? #2

Closed kategengler closed 8 years ago

kategengler commented 9 years ago

Great job on this gem!

I started out using this today with ember-cli-deploy 0.5.x and the redis adapter, it seems that by default, the deploy keys are also prefixed. I had to make this change in the gem:

      def deploy_key
-      redis_client.get(current_key).presence || deployment_not_activated!
+      key = redis_client.get(current_key).presence || deployment_not_activated!
+      "#{namespace}:#{key}"
      end

Should those keys be prefixed?