search

seanpowell / Email-Boilerplate

The email boilerplate for sending out nicely formatted messages.
htmlemailboilerplate.com
3.81k stars 676 forks source link

display:block #4

Closed neilbradley closed 13 years ago

neilbradley commented 13 years ago

Not really an issue as such, but I tend to add display: block to the img declaration in the css: img{height:auto; line-height:100%; outline:none; text-decoration:none; display: block;}

This saves having to add it to each img individually.

seanpowell commented 13 years ago

Hey Neil - Thanks for the input. The only thing that holds me back on this would be instances where you didn't want the image to be a block level element. If you wanted your images to flow with the width of the container element this would break that. With that said, it seems to be common place and accepted to do this (I do it this way too) so it might be fine to add it.

I am open to your thoughts though.

emilchristensen commented 13 years ago

I usually put this in my header: .layout { display:block; } and then I use class="layout" on images that are part of the layout. This way no inline images are being touched.

neilbradley commented 13 years ago

Hey Sean, Perhaps it may be best to keep it as is. I've recently started using Campaign Monitor and their templates all use display: block as in your example where needed. I guess I always used it in this way to apply to everything.

emilchristensen commented 13 years ago

I still Think it's a great idea to have in there, it just shouldn't apply to all images. Adding a layout class helps abstract the process and provides an easy reminder of when and when not to use it.

seanpowell commented 13 years ago

Closing this out. On next release will have fix.