search

seansfkelley / nas-download-manager

An open source browser extension for adding/managing download tasks to your Synology DiskStation.
256 stars 46 forks source link

Unable to switch HTTP/HTTPS in connections settings #150

Closed kirillkushpel closed 4 years ago

kirillkushpel commented 4 years ago

Description

Unable to switch HTTP/HTTPS in connections settings. I've looked through source code, and looks like HTTPS is hardcoded in the state component?

https://github.com/seansfkelley/synology-download-manager/blob/master/src/common/state/1.ts

Steps to Reproduce the Issue

  1. Open extention settings, HTTPS is set by default
  2. Try to switch to HTTP from dropdown list
  3. List won't open

Failure Logs

Not available

Versions

Extension version: 0.7.0

Browser version: Firefox Dev Edition 78.0b8 (64-bit) @Linux Mint 19.3

DSM version: DSM 6.2.3-25426

seansfkelley commented 4 years ago

Hm, I am unable to reproduce this on my mac running Firefox 77 and 79. I'm surprised this is an issue at all -- the dropdown element isn't doing anything fancy and I haven't changed it meaningfully in months or years. Do the other form elements look disabled? When a connection test is running it does disable the inputs, so I wonder if it got into a weird state there somehow.

kirillkushpel commented 4 years ago

It worked one day, then broke) It's a really weird bug, i agree. The thing is that if you use something like ddns, it rarely has HTTPS, and you just can't connect to DSM. Anyway, thanks for the reply :)

seansfkelley commented 4 years ago

For sure, and thanks for the report. Are you able to connect over HTTP now, then?