search

seansfkelley / nas-download-manager

An open source browser extension for adding/managing download tasks to your Synology DiskStation.
257 stars 46 forks source link

extension logs out browser tabs or replaces the logged-in user with the one from the extension #175

Closed Neoyoyo closed 3 years ago

Neoyoyo commented 3 years ago

current status (maintainer edit)

This appears to be an unannounced change/breakage on Synology's part. I have a support ticket open with them now and will post any updates/next steps here. The workaround is to use the same user for the extension as for your normal browser tabs.

original issue follows

Description

Since the update of DSM to version 6.2.4-25554 (on 2021-02-23), if Synology Download Manager is installed there are 2 typex of issues :

Steps to Reproduce the Issue

  1. Install DSM v6.2.4-25554 on the NAS ;
  2. Install Synology Download Manager v0.9.3 in Firefox or Edge and configure it with user account.

Failure Logs

No error in Synology Download Manager, only the behaviour of DSM.

Versions

Extension version : 0.9.3

Browser version : Firefox 86.0

DSM version : 6.2.4-25554

Download Station version : 3.8.15.3563

seansfkelley commented 3 years ago

This sounds like a duplicate of #32, except that that specifically affects DSM versions 5 and below.

Can you try using "Test Connection and Save" in the settings page? It will reset your login session, which could fix the problem. It should also state if it had to use the old login method with a link to issue #32, though I would not expect that to happen for DSM 6.

Neoyoyo commented 3 years ago

Hello, before creating this new issue, I had tested the uninstallation and then the reinstallation of the addon. Without success. I just tested again with the "Test Connection and Save" function but the result is the same.

seansfkelley commented 3 years ago

Thanks for confirming that. It After you tested the connection, it didn't say anything like "connection successful, but may interfere with existing login sessions"?

I'm away from my NAS now for upwards of a month, so unfortunately I won't be able to test and fix this until I'm back. Until then, I can only recommend the workarounds outlined in #32.

Neoyoyo commented 3 years ago

Hi, I confirm, no message such "connection successful, but may interfere with existing login sessions" at connection's test. As a workaround I use another browser for the NAS' administration so don't worry :-)

gvilloresi commented 3 years ago

I am having exactly the same issue. Clearing browser's cache, cookies and using "Test Connection and Save" in the settings page didn't help.

seansfkelley commented 3 years ago

@gvilloresi can you provide the versions of Download Station/Synology Download Manager/browser/DSM you're using?

gvilloresi commented 3 years ago

@seansfkelley Thank you for replying. Here are the versions: Download Station 3.8.16-3566 Synology Download Manager 0.9.3 Firefox 87.0 DSM 6.2.4-25556

Since I am not getting any update notifications, I suppose all of them are currently the latest versions.

seansfkelley commented 3 years ago

Thank you, that's helpful. But unfortunately I still don't have access to my NAS to take a look myself, so for the time being you'll have to use a workaround.

seansfkelley commented 3 years ago

This is an unannounced breaking change on Synology's part.

Issue can be reproduced as follows.

  1. Log into the extension using creds A.
  2. Log into the web interface using the same hostname and creds B.
  3. Hit "Test Connection and Save" in the extension: this force-refreshes the login session.
  4. See that the browser tab has been forcibly logged out or the logged-in account has changed. If not, try refreshing.

In inspecting the network traffic for the login request...

curl -i 'https://<host>:<port>/webapi/auth.cgi?account=<username>&api=SYNO.API.Auth&format=sid&method=login&passwd=<password>&session=DownloadStation&version=4'

I see that set-cookie headers are being sent. In fact, all 6 versions of the auth API send the header, when in the past, version 4 did not (which is how https://github.com/seansfkelley/synology-download-manager/issues/32 was fixed).

huettenwirt commented 3 years ago

Same here. I was searching for a while to find the connection to this extension, but I'm having the same issue of being logged out even as admin on my DSM 6.2.4-25556.

Would be great if you could find a solution to this! Thank you in advance for your great support and best regards!

seansfkelley commented 3 years ago

This should be fixed by version 0.10.0 that I just published.

If you're using Firefox, you should be able to update right now.

If you're using Chrome, I don't know when Google will approve the changes, but watch for any updates there.