seansfkelley / nas-download-manager

An open source browser extension for adding/managing download tasks to your Synology DiskStation.
255 stars 46 forks source link

Unable to add mega.nz links #193

Closed 8bitgentleman closed 3 years ago

8bitgentleman commented 3 years ago

Description

I am unable to add mega.nz links via synology download manager extension. Trying to add the link either manually or via right click fails after a long wait due to an "Unknown Error". I am able to add the same url just fine via the official Download Station UI and via the other (mostly inferior) chrome synology extension "Synology Download Station".

Steps to Reproduce the Issue

  1. Try to add a test mega.nz link

Failure Logs

Redacted extension state: {
  "lastSevereError": "(omitted for brevity)",
  "settings": {
    "badgeDisplayType": "total",
    "connection": {
      "hostname": true,
      "password": true,
      "port": true,
      "protocol": "http",
      "username": true
    },
    "notifications": {
      "completionPollingInterval": 60,
      "enableCompletionNotifications": true,
      "enableFeedbackNotifications": true
    },
    "shouldHandleDownloadLinks": true,
    "taskSortType": "timestamp-added-asc",
    "visibleTasks": {
      "completed": true,
      "downloading": true,
      "errored": true,
      "other": true,
      "uploading": true
    }
  },
  "stateVersion": 5,
  "taskFetchFailureReason": null,
  "tasks": 1,
  "tasksLastCompletedFetchTimestamp": 1622808576487,
  "tasksLastInitiatedFetchTimestamp": 1622808576298
}

3 error(s) while resolving URLs; first message: error while trying to fetch metadata file type for download url

TypeError: 'Failed to fetch'
Error stack trace: TypeError: Failed to fetch

Versions

Extension version: 0.10.3

Browser version: Chromium: 91.0.4472.77 (Official Build) (x86_64)

DSM version: 6.2.4

seansfkelley commented 3 years ago

Hey there, thanks for the report!

I took a look at this, and while there was indeed a bug with the error reporting (since fixed in v0.11.0), it appears that the way that site works isn't compatible with this extension. To get technical, instead of providing a link you can send to the NAS, it downloads the file onto the page, decrypts it, and then programmatically triggers a download from a blob.

8bitgentleman commented 3 years ago

Thanks for looking into this @seansfkelley ! If that's the case how is it that Download Station handles these links? Seems like it uses a pyload plugin for it and gets around the blob issue by using the mega api. Is that something nas-download manager could do as well? (side note did the name of this plugin change today or am I going crazy?) image

seansfkelley commented 3 years ago

I see, in that case, that seems like something I should support. Thanks for providing that example!

8bitgentleman commented 3 years ago

Awesome, thanks for reopening!

seansfkelley commented 3 years ago

Alright, this should be fixed in 0.11.1. Chrome should approve the new release within a day or two.