search

seansfkelley / nas-download-manager

An open source browser extension for adding/managing download tasks to your Synology DiskStation.
256 stars 46 forks source link

[bug] Huge memory usage with lots of downloads #93

Closed ntucker closed 4 years ago

ntucker commented 6 years ago

Versions

Extension version: (visible in Synology Download Manager's settings (Firefox) or in the extension list (Chrome)) 0.5.5 and before

Browser and version: (usually found in the browser's "About") firefox 61.0.2

DSM version: (DSM > Control Panel > Info Center > General > DSM version) DSM 6.2-23739 Update 2

Download Station version: (DSM > Package Center > Installed > Download Station > Installed version) 3.8.10-3509

Steps to Reproduce the Issue

  1. Have >1000 completed downloads in the download manager
  2. either open the download list (even with completed things filtered out) -OR- start a new download
  3. see memory usage skyrocket eating up 95-99% of all system memory on a 16gb machine

Note: I just deleted all completed tasks bring it down to only 5 pages of task and now when i start a new download or open the status it only increases memory by 1-2gigs (still pretty insane tho)

seansfkelley commented 6 years ago

Yikes, that's no good. To clarify, how long does the memory usages stay elevated? Does it improve after you close the popup?

ntucker commented 6 years ago

It stays around for a while depending on how big my history is. Before I deleted the completing things it would take quite sometime - especially since it was thrashing onto the page file for overflowing ram. Now with only 5 pages of downloads it goes back down after maybe 10 seconds

seansfkelley commented 4 years ago

Hey @ntucker, since you filed this issue I've upgraded a bunch of tooling and fixed many small issues that that turned up. None of that was specifically intended to fix this memory issue (as I can't reproduce it), but I'm wondering if you still see this issue with the latest version of the extension.

ntucker commented 4 years ago

I cleared most of my completed downloads and moved my machine to 64GB ram so I haven't been in the conditions to notice if it's still there.

seansfkelley commented 4 years ago

Okay, thanks for the response. I'm going to close this out in that case.