seantempesta / cljs-react-navigation

CLJS wrappers for react-navigation
MIT License
67 stars 23 forks source link

DrawerNavigator wrapper #3

Closed EuAndreh closed 6 years ago

EuAndreh commented 7 years ago

I've noticed that the DrawerNavigator isn't properly wrapped like StackNavigator.

Is there any special reason for not doing so? Is there anybody working on it as of today?

If not, I could happily add that. Would you be interested in it?

By the way, thanks for the library :)

seantempesta commented 7 years ago

Thanks! Yeah, I never wrapped it because I've never used it. Would love a PR. :)

andrew-nguyen commented 7 years ago

@EuAndreh Did you end up working on this? I'm finding a need for it myself. Would be happy to continue from where you left off if you have anything.

EuAndreh commented 7 years ago

@andrew-nguyen Unfortunately, I have not. @seantempesta should I close this issue?

seantempesta commented 7 years ago

Nah. I'll eventually get around to this. I started doing a large refactor and got sidetracked with another project.

carocad commented 6 years ago

@seantempesta I am in need of this myself as well. If it is a simple change (I guess it is) I would like to submit a PR for it.

Just give me some general instructions and I will find my way through

carocad commented 6 years ago

In case anyone is interested. I just created drawer-navigator and drawer-screen options in one of my projects. The code follows the same pattern as the one from @seantempesta. I am hoping that it will eventually be merged but after implementing it I realized why the need to refactor the original project code :)

feedback welcome

vsrinivas150283 commented 6 years ago

I am looking at re-frame implementation of drawer-navigator. It doesn't seem to work like stack-navigator when using router

dotemacs commented 6 years ago

I take it that this issue is resolved by the #9 and can be closed ?