search

seantempesta / expo-cljs-template

Expo template for Clojurescript React Native
Eclipse Public License 1.0
304 stars 33 forks source link

Use expo's registerRootComponent #59

Closed danielneal closed 6 years ago

danielneal commented 6 years ago

I think this should fix #58 (and therefore resolve #46)

I'm not sure about calling .registerRootComponent in advanced builds, though, there might be an externs problem.

I usually use ocall from cljs-oops to circumvent this, but I didn't want to import a library to the template unnecessarily.

seantempesta commented 6 years ago

I'm not opposed to using cljs-oops (which I personally use too). If this is going to break in production then I think we should do something (maybe use goog.object?).

pm4r commented 6 years ago

I can confirm that it also fixes #55

seantempesta commented 6 years ago

Rad. Great work. Thanks for digging into this!