search

seantempesta / expo-cljs-template

Expo template for Clojurescript React Native
Eclipse Public License 1.0
305 stars 33 forks source link

Metro Bundler files Changed - Expo 31.0.0 #74

Closed jamesnyika closed 5 years ago

jamesnyika commented 5 years ago

The following has moved/changed/disappeared:

in the user.clj file there is reference to a node module path that no longer exists. 


....
 (defn enable-source-maps
  []
  (println "Source maps enabled.")
  (let [path "node_modules/metro/src/Server/index.js"]
    (spit path
          (str/replace (slurp path) "/\\.map$/" "/main.map$/"))))

....

My best guess is that is has been replaced by 

node_modules/metro/src/server.js

but I am not sure. If you can give me a clue as to what this file is doing ... I can try and figure out and create a PR..

thanks

seantempesta commented 5 years ago

Well in the past they've just moved the file, but the search/replace still worked. Have you tried running the code on the node_modules/metro/src/server.js?

jamesnyika commented 5 years ago

I have. And it resolves the exception that you would receive. I hope it does in any way lead to Issue 73. So when you update your Expo SDK to 31, you will need to make this change to your user.cljs file.